feat: move buffer size control to RunConfig#209
Merged
Conversation
johnnygreco
approved these changes
Jan 13, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change moves dataset generation buffer sizing into
RunConfig, making runtime execution settings explicit and centralized.RunConfig.buffer_size(default: 1000, validated viaField(gt=0)).ColumnWiseDatasetBuilder.build(...)readbuffer_sizefromResourceProvider.run_config(removes the explicitbuffer_sizeargument).DataDesigner’s buffer configuration helper (set_buffer_size) and its internal_buffer_sizestate.RunConfig.Motivation
Previously, buffer sizing lived on
DataDesignervia a separate helper method, while other runtime/execution controls (early shutdown, retry limits) lived onRunConfig. That split made it harder for users to discover, reason about, and persist “how generation runs” settings.By consolidating
buffer_sizeintoRunConfig, all runtime knobs that affect execution behavior now live in one place, and the engine consistently reads them from a single source (ResourceProvider.run_config). This clarifies dataset generation settings, makes configs easier to share/reuse, and reduces the chance of configuration drift between interface and engine.Behavior / impact
RunConfig().buffer_size == 1000.buffer_sizecontrols end-to-end batch size during persisted generation: one batch is generated, post-batch processors run, and the batch is written to artifact storage before the next batch begins.DataDesigner.set_buffer_size(...)was removed. Buffer sizing is now configured only viaRunConfig.Usage example
Tests
buffer_sizebehavior and to reflect the removed helper API.