feat: Plumb LLM retry controls through RunConfig#208
Merged
Conversation
nabinchha
approved these changes
Jan 13, 2026
johnnygreco
reviewed
Jan 13, 2026
johnnygreco
approved these changes
Jan 13, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces global, user-configurable controls for LLM generation retry effort via
RunConfig, and removes prior module-level hardcoding inside generation tasks (notablyllm_completiongenerators and LLM judge). This is a necessary change so users can explicitly bound/scale effort spent per sample (latency/cost/stability) across all tasks that rely onModelFacade.generate().What changed
RunConfigfields (single source of truth):max_conversation_restarts: int(default 5,ge=0)max_conversation_correction_steps: int(default 0,ge=0)llm_completiongeneratorsself.resource_provider.run_configLLMJudgeCellGeneratorused a 2× restart multiplier relative to the module default.RunConfigvalues as other LLM completion generators.Why this is needed (user impact)
LLM generation effort per sample was previously implicitly determined by internal defaults (and judge had an additional multiplier), making it difficult for users to:
With this change, users can control these tradeoffs in one place.
Behavioral impact / compatibility notes
RunConfig.max_conversation_restarts=5,max_conversation_correction_steps=0matches the previous LLM generator defaults.RunConfig.Plumbing details
DataDesigneralready threadsRunConfiginto the engine viaResourceProvider.run_config.run_configvalues into:ModelFacade.generate(max_correction_steps=..., max_conversation_restarts=...)Example usage
Files changed
src/data_designer/config/run_config.pysrc/data_designer/engine/column_generators/generators/llm_completion.pytests/engine/column_generators/generators/test_llm_completion_generators.pytests/interface/test_data_designer.pyTests
run_configvalues intomodel.generate(...).