Improved Performance for Fixed List Columns#97
Closed
oliverholworthy wants to merge 7 commits intoNVIDIA-Merlin:mainfrom
Closed
Improved Performance for Fixed List Columns#97oliverholworthy wants to merge 7 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy wants to merge 7 commits intoNVIDIA-Merlin:mainfrom
Conversation
karlhigley
reviewed
Mar 16, 2023
| except ImportError: | ||
| cp = np | ||
|
|
||
| try: |
Contributor
There was a problem hiding this comment.
This could use cudf from merlin.core.compat but that's a tiny nit that need not block this PR 🤷🏻
Contributor
Author
There was a problem hiding this comment.
Once NVIDIA-Merlin/core#244 is merged we'll be able to. (There's still one thing to fix on that PR)
karlhigley
approved these changes
Mar 16, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal: Load Fixed List Columns more quickly.
Columns with fixed and ragged list features currently take significanlty longer to load compared with scalar features. See #82
This is a first step toward making list features load more quickly.
Handling the special case of fixed list features where the lists are all of the same length, we can bypass some of the slower code that handles ragged lists and load these more quickly.