Remove padding from NVTabular getting started example#677
Merged
oliverholworthy merged 8 commits intoNVIDIA-Merlin:mainfrom May 4, 2023
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-677 |
rnyak
approved these changes
Apr 21, 2023
Contributor
|
@oliverholworthy this looks like ready to me, but it reads Draft. |
rnyak
reviewed
Apr 26, 2023
| @@ -63,18 +63,7 @@ | |||
| "execution_count": 2, | |||
Contributor
Contributor
Author
There was a problem hiding this comment.
let me re-run both notebooks again. I only commited the part of the first notebook that had changed
Contributor
Author
There was a problem hiding this comment.
run all the notebooks now and should match up now with the schema
Contributor
|
@oliverholworthy I pulled the latest main branches and then your PR and I am getting error from unit test from first ETL notebook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demonstrates how we can serve Transformers4Rec and NVTabular together with ragged outputs from the workflow and ragged inputs into the model