Skip to content

Add workflow to check if base branch of pull request is development#656

Merged
oliverholworthy merged 4 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy:base-branch-check
Mar 31, 2023
Merged

Add workflow to check if base branch of pull request is development#656
oliverholworthy merged 4 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy:base-branch-check

Conversation

@oliverholworthy
Copy link
Copy Markdown
Contributor

@oliverholworthy oliverholworthy commented Mar 24, 2023 •
edited
Loading

Part of NVIDIA-Merlin/Merlin#866

Adding a check to ensure we create pull requests into the development branch of the repo.

If you create a pull request into a branch that is not the development branch, you'll receive something like the following error:

Error: Pull Request base ref must be the development branch: 'main'. Found base ref: 'release-23.02' .
If you're sure you need to merge this change into 'release-23.02' instead. 
You can add the label 'skip-base-branch-check'.

@oliverholworthy oliverholworthy self-assigned this Mar 24, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.03 milestone Mar 24, 2023
@oliverholworthy oliverholworthy changed the base branch from release-23.02 to main March 24, 2023 17:50
@oliverholworthy oliverholworthy marked this pull request as ready for review March 24, 2023 17:51
@oliverholworthy
Copy link
Copy Markdown
Contributor Author

oliverholworthy commented Mar 24, 2023

Example of this check failing on this PR https://github.com/NVIDIA-Merlin/Transformers4Rec/actions/runs/4513972526/jobs/7949481091 before I updated the base branch to main

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2023

Documentation preview

https://nvidia-merlin.github.io/Transformers4Rec/review/pr-656

@oliverholworthy oliverholworthy changed the title Add workflow to check of base branch of pull request is development Add workflow to check if base branch of pull request is development Mar 24, 2023
@oliverholworthy oliverholworthy merged commit 9400658 into NVIDIA-Merlin:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nv-alaiacano nv-alaiacano nv-alaiacano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oliverholworthy oliverholworthy

Labels

ci

Projects

None yet

Milestone

Merlin 23.03

Development

Successfully merging this pull request may close these issues.

2 participants

@oliverholworthy @nv-alaiacano