Skip to content

Separate notebook tests into their own tox environment#653

Merged
karlhigley merged 7 commits intomainfrom
laiacano/nb-tests
Mar 22, 2023
Merged

Separate notebook tests into their own tox environment#653
karlhigley merged 7 commits intomainfrom
laiacano/nb-tests

Conversation

@nv-alaiacano
Copy link
Copy Markdown
Contributor

@nv-alaiacano nv-alaiacano commented Mar 21, 2023

[updated]
This PR rearranges some things so that we can test notebooks in an integration-test style. In particular it:

  • Splits tests/ into tests/unit and tests/integration with all notebooks in the integration directory
  • Adds a tox testenv test-cpu-integration and test-gpu-integration and installs the necessary Merlin libraries in it
  • Adds/modifies github actions to run the new tests

Goals ⚽

Implementation Details 🚧

Testing Details 🔍

@nv-alaiacano nv-alaiacano added chore Maintenance for the repository ci labels Mar 21, 2023
@nv-alaiacano nv-alaiacano requested a review from rnyak March 21, 2023 18:49
@nv-alaiacano nv-alaiacano self-assigned this Mar 21, 2023
@github-actions
Copy link
Copy Markdown

@nv-alaiacano nv-alaiacano requested a review from karlhigley March 22, 2023 14:22
@nv-alaiacano nv-alaiacano added this to the Merlin 23.03 milestone Mar 22, 2023
@karlhigley karlhigley merged commit 6a17a1c into main Mar 22, 2023
@rnyak rnyak deleted the laiacano/nb-tests branch March 22, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance for the repository ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants