Allow Schema class from core to be used to create input-blocks#634
Merged
marcromeyn merged 3 commits intomainfrom Mar 10, 2023
Merged
Allow Schema class from core to be used to create input-blocks#634marcromeyn merged 3 commits intomainfrom
marcromeyn merged 3 commits intomainfrom
Conversation
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-634 |
| Optional[TabularModule] | ||
| """ | ||
| schema_copy = schema.copy() | ||
| schema_copy = deepcopy(schema) |
Contributor
There was a problem hiding this comment.
is this deepcopy required for the Merlin Core Schema?
Contributor
There was a problem hiding this comment.
We could add a copy method to the core schema that would avoid the need for deepcopy
oliverholworthy
approved these changes
Mar 9, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals ⚽
The goal is to deprecate the
Schemaclass inmerlin_standard_libin favor of the one in merlin-core. In order to give our users some time for this breaking change, this PR adds support for providing both the Schema definitions to create input-blocks.The next step would be to do the same for the
Trainerclass.Testing Details 🔍
This PR adds some parameterization in order to test the creation of input-blocks from both the Schema definitions.