Migrate schema Tags to merlin.schema.Tags#632
Merged
nv-alaiacano merged 11 commits intomainfrom Mar 9, 2023
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Documentation previewhttps://nvidia-merlin.github.io/Transformers4Rec/review/pr-632 |
4976eb6 to
d49a9d8
Compare
nv-alaiacano
commented
Mar 8, 2023
| **kwargs, | ||
| ) -> "ColumnSchema": | ||
| _tags: List[str] = [str(t) for t in tags] if tags else [] | ||
| _tags: List[str] = [t.value for t in TagSet(tags or [])] |
Contributor
Author
There was a problem hiding this comment.
This is something I don't love - _tags is a List[str] not a TagsType. We convert actual Tags to their string value, but I don't think we convert them back anywhere. I need to understand it a little more now that the tests are passing (hopefully)
Contributor
There was a problem hiding this comment.
I agree. I think we converted to strings everywhere to make it easier for users to provide custom tags as strings. Not completely sure how we handle that currently across Merlin.
marcromeyn
approved these changes
Mar 9, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses NVIDIA-Merlin/Merlin#844
Current status is that all tests pass except the getting-started notebooks.
Fixes # (issue)
Goals ⚽
Implementation Details 🚧
Testing Details 🔍