Skip to content

Update usage of use_amp to use_cuda_amp for transformers>=4.20#627

Merged
karlhigley merged 4 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy:transformers-update-4.20
Mar 22, 2023
Merged

Update usage of use_amp to use_cuda_amp for transformers>=4.20#627
karlhigley merged 4 commits intoNVIDIA-Merlin:mainfrom
oliverholworthy:transformers-update-4.20

Conversation

@oliverholworthy
Copy link
Copy Markdown
Contributor

@oliverholworthy oliverholworthy commented Mar 1, 2023 •
edited
Loading

Relates to #568

  • Support transformers package version >=4.20
  • and earlier versions too by checking both use_cuda_amp and use_amp attributes in the trainer.

@oliverholworthy oliverholworthy added the chore Maintenance for the repository label Mar 1, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.03 milestone Mar 1, 2023
@oliverholworthy oliverholworthy self-assigned this Mar 1, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 1, 2023

Documentation preview

https://nvidia-merlin.github.io/Transformers4Rec/review/pr-627

@oliverholworthy oliverholworthy marked this pull request as ready for review March 22, 2023 11:05
@karlhigley karlhigley merged commit ed88361 into NVIDIA-Merlin:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@karlhigley karlhigley karlhigley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oliverholworthy oliverholworthy

Labels

chore Maintenance for the repository

Projects

None yet

Milestone

Merlin 23.03

Development

Successfully merging this pull request may close these issues.

2 participants

@oliverholworthy @karlhigley