Skip to content

Simplify getting-started ETL and fix serving with torch script notebook#604

Merged
rnyak merged 3 commits intomainfrom
fix_gettingstarted_nb
Jan 25, 2023
Merged

Simplify getting-started ETL and fix serving with torch script notebook#604
rnyak merged 3 commits intomainfrom
fix_gettingstarted_nb

Conversation

@rnyak
Copy link
Copy Markdown
Contributor

@rnyak rnyak commented Jan 24, 2023

This PR does the following:

  • fix getting-started ETL notebook text, and remove unnecessary ValueCount ops from the workflow
  • fix the dtype error coming from df_cols[name] = tensor.cpu().numpy().astype(dtype) line.

@rnyak rnyak added enhancement New feature or request area/inference labels Jan 24, 2023
@rnyak rnyak requested a review from sararb January 24, 2023 22:05
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rnyak rnyak requested a review from bbozkaya January 24, 2023 22:10
@github-actions
Copy link
Copy Markdown

@rnyak rnyak added this to the Merlin 23.01 milestone Jan 25, 2023
@rnyak rnyak merged commit ca0f92f into main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/inference enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants