Skip to content

fixing name and bug in MeanReciprocalRankAt#513

Closed
tetelias wants to merge 2 commits intoNVIDIA-Merlin:mainfrom
tetelias:main
Closed

fixing name and bug in MeanReciprocalRankAt#513
tetelias wants to merge 2 commits intoNVIDIA-Merlin:mainfrom
tetelias:main

Conversation

@tetelias
Copy link
Copy Markdown

@tetelias tetelias commented Nov 1, 2022

Fixes # (issue)
[BUG] #509

Goals ⚽

Fixes the problem with one of the tensors always created on CPU even if data is processed with GPU.
Also name is corrected.

Implementation Details 🚧

Tensor is placed on the same device as previously created one.

Testing Details 🔍

Other metrics are not tested so I don't have a guidance for the process and the bug/naming is rather straightforward so there is no tests.

@nvidia-merlin-bot
Copy link
Copy Markdown

nvidia-merlin-bot commented Nov 1, 2022

Click to view CI Results
GitHub pull request #513 of commit 0732292df37d1cf427785608858f5590e0bcf6ab, no merge conflicts.
Running as SYSTEM
Setting status of 0732292df37d1cf427785608858f5590e0bcf6ab to PENDING with url http://10.20.17.181:8080/job/transformers4rec_tests/232/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/transformers4rec_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/Transformers4Rec.git
 > git init /var/jenkins_home/workspace/transformers4rec_tests/transformers4rec # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Transformers4Rec.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Transformers4Rec.git +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Transformers4Rec.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Transformers4Rec.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Transformers4Rec.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Transformers4Rec.git +refs/pull/513/*:refs/remotes/origin/pr/513/* # timeout=10
 > git rev-parse 0732292df37d1cf427785608858f5590e0bcf6ab^{commit} # timeout=10
Checking out Revision 0732292df37d1cf427785608858f5590e0bcf6ab (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 0732292df37d1cf427785608858f5590e0bcf6ab # timeout=10
Commit message: "fixing name and bug in MeanReciprocalRankAt"
 > git rev-list --no-walk 6dea3fe7ad046fa643b27e77439037ead84b51d3 # timeout=10
[transformers4rec_tests] $ /bin/bash /tmp/jenkins3200474818174650985.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.3, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/transformers4rec_tests/transformers4rec
plugins: anyio-3.6.1, xdist-3.0.2, cov-4.0.0
collected 1 item

tests/unit/test_notebooks.py .                                           [100%]


============================== 1 passed in 36.35s ==============================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=2 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Transformers4Rec/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[transformers4rec_tests] $ /bin/bash /tmp/jenkins16661584845270059641.sh

@rnyak
Copy link
Copy Markdown
Contributor

rnyak commented Nov 1, 2022 •
edited by sararb
Loading

@tetelias thanks for the PR. can you please reformat the files. you can install isort, black and flake8 and run them to fix any pre-commit issues before committing. or you can do the following before commiting:

pip install pre-commit
pre-commit install
pre-commit run --all-files

@rnyak rnyak added area/api chore Maintenance for the repository labels Nov 1, 2022
@sararb sararb added the bug Something isn't working label Nov 3, 2022
@rnyak rnyak added the P1 label Nov 4, 2022
@nvidia-merlin-bot
Copy link
Copy Markdown

nvidia-merlin-bot commented Nov 8, 2022

Click to view CI Results
GitHub pull request #513 of commit 2118ed166b624d8511c269add03cb0ef9e8260a1, no merge conflicts.
Running as SYSTEM
Setting status of 2118ed166b624d8511c269add03cb0ef9e8260a1 to PENDING with url http://merlin-infra1.nvidia.com:8080/job/transformers4rec_tests/247/ and message: 'Build started for merge commit.'
Using context: Jenkins Unit Test Run
Building on master in workspace /var/jenkins_home/workspace/transformers4rec_tests
using credential nvidia-merlin-bot
Cloning the remote Git repository
Cloning repository https://github.com/NVIDIA-Merlin/Transformers4Rec.git
 > git init /var/jenkins_home/workspace/transformers4rec_tests/transformers4rec # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Transformers4Rec.git
 > git --version # timeout=10
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Transformers4Rec.git +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Transformers4Rec.git # timeout=10
 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
 > git config remote.origin.url https://github.com/NVIDIA-Merlin/Transformers4Rec.git # timeout=10
Fetching upstream changes from https://github.com/NVIDIA-Merlin/Transformers4Rec.git
using GIT_ASKPASS to set credentials This is the bot credentials for our CI/CD
 > git fetch --tags --force --progress -- https://github.com/NVIDIA-Merlin/Transformers4Rec.git +refs/pull/513/*:refs/remotes/origin/pr/513/* # timeout=10
 > git rev-parse 2118ed166b624d8511c269add03cb0ef9e8260a1^{commit} # timeout=10
Checking out Revision 2118ed166b624d8511c269add03cb0ef9e8260a1 (detached)
 > git config core.sparsecheckout # timeout=10
 > git checkout -f 2118ed166b624d8511c269add03cb0ef9e8260a1 # timeout=10
Commit message: "Merge branch 'main' into main"
 > git rev-list --no-walk 090d681d5b4489587cfe244062efc943d903cc8b # timeout=10
First time build. Skipping changelog.
[transformers4rec_tests] $ /bin/bash /tmp/jenkins7229623224667234149.sh
============================= test session starts ==============================
platform linux -- Python 3.8.10, pytest-7.1.3, pluggy-1.0.0
rootdir: /var/jenkins_home/workspace/transformers4rec_tests/transformers4rec
plugins: anyio-3.6.1, xdist-3.0.2, cov-4.0.0
collected 1 item

tests/unit/test_notebooks.py .                                           [100%]


============================== 1 passed in 37.55s ==============================

Performing Post build task...

Match found for : : True

Logical operation result is TRUE

Running script  : #!/bin/bash

cd /var/jenkins_home/

CUDA_VISIBLE_DEVICES=2 python test_res_push.py "https://api.GitHub.com/repos/NVIDIA-Merlin/Transformers4Rec/issues/$ghprbPullId/comments" "/var/jenkins_home/jobs/$JOB_NAME/builds/$BUILD_NUMBER/log"

[transformers4rec_tests] $ /bin/bash /tmp/jenkins2486753829767047159.sh

@rnyak rnyak mentioned this pull request Nov 8, 2022
Merged
@rnyak
Copy link
Copy Markdown
Contributor

rnyak commented Nov 8, 2022

closing since we fix that here #522

@rnyak rnyak closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sararb sararb sararb approved these changes

@gabrielspmoreira gabrielspmoreira Awaiting requested review from gabrielspmoreira

Assignees

No one assigned

Labels

area/api bug Something isn't working chore Maintenance for the repository P1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tetelias @nvidia-merlin-bot @rnyak @sararb