Skip to content

refactor: Move NormalizeSearchPaths into lookup package#1660

Merged
elezar merged 2 commits intoNVIDIA:mainfrom
elezar:refactor-normalize-search-paths
Feb 18, 2026
Merged

refactor: Move NormalizeSearchPaths into lookup package#1660
elezar merged 2 commits intoNVIDIA:mainfrom
elezar:refactor-normalize-search-paths

Conversation

@elezar
Copy link
Member

@elezar elezar commented Feb 17, 2026

This change moves the root.normalizeSearchPaths package to
lookup.NormalizePaths and ensures that this is called when setting
the search paths on Locator construction. This means that the caller
does not have to add this call to handle cases where the search paths
may be a ":"-separated list.

@elezar elezar requested review from jgehrcke and klueska February 17, 2026 14:07
@elezar elezar force-pushed the refactor-normalize-search-paths branch from f87fc3c to ca3cb22 Compare February 17, 2026 14:55
@coveralls
Copy link

coveralls commented Feb 17, 2026

Pull Request Test Coverage Report for Build 22133004637

Details

  • 13 of 20 (65.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 38.983%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/lookup/path.go 6 7 85.71%
internal/lookup/root/root.go 1 3 33.33%
internal/test/test.go 0 4 0.0%
Totals Coverage Status
Change from base Build 22132826107: 0.03%
Covered Lines: 5704
Relevant Lines: 14632

💛 - Coveralls

Copy link
Collaborator

@jgehrcke jgehrcke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

This change moves the root.normalizeSearchPaths package to
lookup.NormalizePaths and ensures that this is called when setting
the search paths on Locator construction. This means that the caller
does not have to add this call to handle cases where the search paths
may be a :-separated list.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the refactor-normalize-search-paths branch from ca3cb22 to 58ab450 Compare February 18, 2026 08:55
@elezar elezar merged commit e6d6889 into NVIDIA:main Feb 18, 2026
16 checks passed
@elezar elezar deleted the refactor-normalize-search-paths branch February 18, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants