Separate nvcdi construction options from runtime options#1659
Merged
elezar merged 7 commits intoNVIDIA:mainfrom Feb 20, 2026
Merged
Separate nvcdi construction options from runtime options#1659elezar merged 7 commits intoNVIDIA:mainfrom
elezar merged 7 commits intoNVIDIA:mainfrom
Conversation
Pull Request Test Coverage Report for Build 22141762110Details
💛 - Coveralls |
5a99fe2 to
cec1b16
Compare
4375034 to
08f5ebf
Compare
This adds basic tests for the following modes: * imex * csv Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change stores the mode in the gatedlib struct instead of requiring that it be associated with the nvcdilib type. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change moves the determination of the mode-specific default vendor to a function attached to the options type. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change moves the determination of the mode-specific default class to a function attached to the options type. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
08f5ebf to
7481055
Compare
klueska
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change pulls the options required by the
nvcdilibtype to construct the type to a newoptionstype. These values are then used to isntantiate annvcdilibinstance with with the values required to generate the CDI spec as required.