Merged
Conversation
Pull Request Test Coverage Report for Build 22178121089Details
💛 - Coveralls |
3a858c6 to
23d3db8
Compare
cdesiniotis
reviewed
Feb 18, 2026
Contributor
cdesiniotis
left a comment
There was a problem hiding this comment.
LGTM besides one typo
internal/discover/gdrcopy.go
Outdated
| return NewCharDeviceDiscoverer( | ||
| logger, | ||
| devRoot, | ||
| driver.Root, |
Contributor
There was a problem hiding this comment.
Did you mean driver.DevRoot?
Member
Author
There was a problem hiding this comment.
Yes. Good catch. Let me add a test too.
Member
Author
There was a problem hiding this comment.
I've added tests for some fo the basic discoverers that at least caught this bug.
1efb187 to
1993f8e
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
1993f8e to
ee73673
Compare
These changes add basic tests for the following discoverers: * gdrcopy * gds * mofed * nvswitch * tegra * dgpu (non-mig) Signed-off-by: Evan Lezar <elezar@nvidia.com>
Instead of passing driverRoot and devRoot separately, we add a DevRoot to the Driver type and pass a reference to a driver instead. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
ee73673 to
a5784ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes add a
DevRootmember to the driver type. This means that thedriverRoot(for libraries and executables) and thedevRootneed not be tracked separately.