refactor: Move update-ldcache argument processing into hook creator#1651
Merged
elezar merged 1 commit intoNVIDIA:mainfrom Feb 17, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 22089797737Details
💛 - Coveralls |
Instead of keeping track of the ldconfig path for hook creation, we encapsulate this value in the HookCreator options. This means that this value can be set once and reused when creating these hooks. Signed-off-by: Evan Lezar <elezar@nvidia.com>
82fc75b to
ee0fe38
Compare
jgehrcke
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of keeping track of the ldconfig path for hook creation, we encapsulate this value in the HookCreator options. This means that this value can be set once and reused when creating these hooks.