Merged
Conversation
187c0b5 to
56cb161
Compare
56cb161 to
4b41e28
Compare
Pull Request Test Coverage Report for Build 21762024183Details
💛 - Coveralls |
This change adds an internal devices package that allows for overriding device-node specific function for testing. This replaces the use of the __NVCT_TESTING_DEVICES_ARE_FILES envvar. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change is a minor improvemnt -- mostly for testing -- where the device Path is used to query device information if the HostPath is not set. Signed-off-by: Evan Lezar <elezar@nvidia.com>
4b41e28 to
d957974
Compare
jgehrcke
approved these changes
Feb 10, 2026
Collaborator
jgehrcke
left a comment
There was a problem hiding this comment.
to allow for tests to specify mocks used in discovery.
Nice! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to make changes related to device nodes more testable, these changes refactor the way they are discovered in tests to allow for tests to specify mocks used in discovery.
We also replace the logic to check the
__NVCT_TESTING_DEVICES_ARE_FILESenvvar when discovering device nodes on our test file systems with stubs that can be overridden per test.This was motivated by #1631 and #630.