Skip to content

fix: Log actual CDI spec version#1633

Merged
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-logged-spec-version
Feb 6, 2026
Merged

fix: Log actual CDI spec version#1633
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-logged-spec-version

Conversation

@elezar
Copy link
Member

@elezar elezar commented Feb 6, 2026

This change ensures that we log the ACTUAL CDI spec version generated and not the version associated with the imported go package.

Without this change:

INFO[0000] Generated CDI spec with version 1.1.0

With this change the logs include:

INFO[0000] Generated CDI spec with version 0.5.0

This change ensures that we log the ACTUAL CDI spec version
generated and not the version associated with the imported go package.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar added this to the v1.18.3 milestone Feb 6, 2026
@elezar elezar added the bug Issue/PR to expose/discuss/fix a bug label Feb 6, 2026
@elezar
Copy link
Member Author

elezar commented Feb 6, 2026

/cherry-pick release-1.18

@elezar elezar merged commit c7281f3 into NVIDIA:main Feb 6, 2026
13 checks passed
@elezar elezar deleted the fix-logged-spec-version branch February 6, 2026 15:29
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

🤖 Backport PR created for release-1.18: #1634

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21755946027

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 39.563%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/nvidia-ctk/cdi/generate/generate.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
cmd/nvidia-ctk/cdi/generate/generate.go 1 45.71%
Totals Coverage Status
Change from base Build 21750501419: -0.003%
Covered Lines: 5724
Relevant Lines: 14468

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue/PR to expose/discuss/fix a bug cherry-pick/release-1.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants