Skip to content

fix: Fix arguments when creating DRM device symlinks#1563

Merged
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-dri-symlinks
Jan 12, 2026
Merged

fix: Fix arguments when creating DRM device symlinks#1563
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-dri-symlinks

Conversation

@elezar
Copy link
Member

@elezar elezar commented Jan 8, 2026

With the move to a HookCreator to manage the creation of create-symlink hooks, the --link argument is handled internally and the arguments passed to the creator are the links themselves. This change remove the redundant --link arguments.

This bug was introduced in #1090 and may cause use cases that rely on the legacy mode in v1.18.x to fail when NVIDIA_DRIVER_CAPABILITIES includes graphics or display.

Fixes #1555.

With the move to a HookCreator to manage the creation of create-symlink
hooks, the --link argument is handled internally and the arguments passed
to the creator are the links themselves. This change remove the redundant
--link arguments.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar added this to the v1.18.2 milestone Jan 8, 2026
@elezar elezar added the bug Issue/PR to expose/discuss/fix a bug label Jan 8, 2026
@elezar
Copy link
Member Author

elezar commented Jan 8, 2026

/cherry-pick release-1.18

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20818767110

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 37.165%

Totals Coverage Status
Change from base Build 20780372953: 0.3%
Covered Lines: 5251
Relevant Lines: 14129

💛 - Coveralls

@elezar elezar merged commit 855e124 into NVIDIA:main Jan 12, 2026
16 checks passed
@github-actions
Copy link

🤖 Backport PR created for release-1.18: #1568

@elezar elezar deleted the fix-dri-symlinks branch January 15, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue/PR to expose/discuss/fix a bug cherry-pick/release-1.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After upgrading to the following version, when I configured NVIDIA_VISIBLE_DEVICES=none, nvidia-smi was able to detect all the devices.

3 participants