Add debug-level log option for ctk-installer#1551
Merged
elezar merged 2 commits intoNVIDIA:mainfrom Feb 13, 2026
Merged
Conversation
elezar
reviewed
Jan 19, 2026
cmd/nvidia-ctk-installer/main.go
Outdated
|
|
||
| var availableRuntimes = map[string]struct{}{"docker": {}, "crio": {}, "containerd": {}} | ||
| var defaultLowLevelRuntimes = []string{"runc", "crun"} | ||
| var ( |
Member
There was a problem hiding this comment.
If you're going to make these changes please make them in a separate commit.
Contributor
Author
There was a problem hiding this comment.
Nothing changed here, auto-formated by the gofumpt formatter.
elezar
reviewed
Jan 19, 2026
Member
elezar
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
I have made a proposal for using log-verbosity instead as well as some other changes that better align with some things that I've been considering recently.
Please feel free to squash / clean up as required.
5d80b24 to
6f4666c
Compare
Pull Request Test Coverage Report for Build 21825020489Details
💛 - Coveralls |
elezar
approved these changes
Feb 5, 2026
Member
|
/ok-to-test 2cc32fd |
This change adds a --debug flag to the nvidia-ctk-installer to set the log level for INSTALLATION to debug. This does not change the log level of the installed toolkit. Signed-off-by: Jactor Sue <jactor_sue@live.com> Co-authored-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
2cc32fd to
1e37ca3
Compare
elezar
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable debug-level log for nvidia-ctk-installer cmd by
--debugor-d.