Skip to content

fix: Return error on JIT CDI spec generation failure#1538

Merged
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:return-on-jid-cdi-error
Jan 6, 2026
Merged

fix: Return error on JIT CDI spec generation failure#1538
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:return-on-jid-cdi-error

Conversation

@elezar
Copy link
Member

@elezar elezar commented Dec 11, 2025

This change ensures that errors that occur when generating jit CDI specs are returned instead of silently ignored.

Fixes #1537

This change ensures that errors that occur when generating jit CDI specs
are returned instead of silently ignored.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar added this to the v1.18.2 milestone Dec 11, 2025
@elezar
Copy link
Member Author

elezar commented Dec 11, 2025

/cherry-pick release-1.18

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20127957081

Details

  • 0 of 12 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 36.922%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/modifier/cdi.go 0 12 0.0%
Totals Coverage Status
Change from base Build 20098009221: -0.005%
Covered Lines: 5203
Relevant Lines: 14092

💛 - Coveralls

@elezar elezar merged commit 309013d into NVIDIA:main Jan 6, 2026
16 checks passed
@elezar elezar deleted the return-on-jid-cdi-error branch January 6, 2026 15:29
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

🤖 Backport PR created for release-1.18: #1557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Treat failures in automatic CDI spec generation as an error

3 participants