Closed
Conversation
This change makes the nvdevices and nvmodules packages public to allow this functionality to be consumed by other clients directly. These include the mig-manager and the gpu-operator. Signed-off-by: Evan Lezar <elezar@nvidia.com>
This change adds a CreateDevCharSymlinks function to the API of the nvdevices packages. The implementation in nvidia-ctk system create-dev-char-symlinks is updated to use this API. This allows the GPU Operator to move to this API instead of importing the cmd/system/create-dev-char-symlinks package. Signed-off-by: Evan Lezar <elezar@nvidia.com>
2e90474 to
e71e6dc
Compare
|
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label. |
Member
Author
|
This was superceded by #1577 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change promotes the system/nvdevices package to public so that it can directly be consumed by mig-parted.