Add drop-in file support for containerd and crio#1280
Merged
elezar merged 2 commits intoNVIDIA:mainfrom Sep 19, 2025
Merged
Conversation
303181d to
b332388
Compare
d731b7c to
5d803d2
Compare
5d803d2 to
dd480aa
Compare
elezar
commented
Sep 18, 2025
Signed-off-by: Evan Lezar <elezar@nvidia.com>
dd480aa to
488c9fe
Compare
Collaborator
|
/retitle "Implement Drop-In Lifecycle Support for Containerd and Crio" |
0f3597d to
62cffba
Compare
This change adds drop-in file support for containerd and crio. Instead of writing the entire in-memory config to the specified config path, we write only the modified settings (nvidia runtimes, default runtime, enable_cdi) settings to a drop-in file and update the top-level configs to import this if required. Signed-off-by: Evan Lezar <elezar@nvidia.com> Co-authored-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
62cffba to
abcba21
Compare
cdesiniotis
reviewed
Sep 19, 2025
Comment on lines
+53
to
+56
| func (c *Config) AddRuntime(name string, path string, setAsDefault bool) error { | ||
| options := c.Source.GetDefaultRuntimeOptions() | ||
| return c.Destination.AddRuntimeWithOptions(name, path, setAsDefault, options) | ||
| } |
Contributor
There was a problem hiding this comment.
I believe this means the changes I made in #1256 will no longer take affect. If default_runtime_name=nvidia is set in the top-level config, and setAsDefault=false, we don't actually unset nvidia as the default runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds drop-in file support for containerd and crio. Instead of writing the entire in-memory config to the specified config path, we write only the modified settings (nvidia runtimes, default runtime, enable_cdi) settings to a drop-in file and update the top-level configs to import this if required.
See also #1272
For GPU Operator integration see NVIDIA/gpu-operator#1710