Merged
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
57ad7b9 to
538bc0d
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
538bc0d to
c7a5eb6
Compare
Collaborator
|
It feels a little weird to introduce a Dockerfile just for dependency tracking (and not to actually build a docker container from), but I see why you are doing it to integrate with existing tools, so its OK. |
klueska
approved these changes
Jan 22, 2026
Member
Author
This is the same mechanism we use in other projects to automate the golang bump. I understand that there we also have a development image that we sometimes use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change bumps the default
GOLANG_VERSIONto v1.25.6. It also adds the-buildvcs=falseflag as required as of go1.18 to enable the containerized builds.