Add CAP_SYS_ADMIN if volume-mounts list strategy is included#873
Merged
elezar merged 7 commits intoNVIDIA:mainfrom Aug 7, 2024
Merged
Add CAP_SYS_ADMIN if volume-mounts list strategy is included#873elezar merged 7 commits intoNVIDIA:mainfrom
elezar merged 7 commits intoNVIDIA:mainfrom
Conversation
elezar
commented
Aug 6, 2024
| @@ -0,0 +1,132 @@ | |||
| /** | |||
Member
Author
There was a problem hiding this comment.
I still need to add the logic to run these tests.
Contributor
There was a problem hiding this comment.
Meaning you have run them locally and they pass, but there is nothing to trigger them automatically yet?
Member
Author
There was a problem hiding this comment.
Yes. I am able to run the tests by running go tests in the tests/helm folder, but need to add some make targets and CI jobs.
klueska
reviewed
Aug 6, 2024
deployments/helm/nvidia-device-plugin/templates/daemonset-device-plugin.yml
Show resolved
Hide resolved
klueska
reviewed
Aug 6, 2024
58e7695 to
da0d476
Compare
cdesiniotis
reviewed
Aug 7, 2024
Contributor
cdesiniotis
left a comment
There was a problem hiding this comment.
Thanks @elezar, this lgtm. I left a few minor comments / questions.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
cdesiniotis
approved these changes
Aug 7, 2024
klueska
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the
SYS_ADMINcapability is added ifvolume-mountsare included in the device list strategy. This ensures that the device plugin functions correctly if the NVIDIA Container Toolkit is configured to use volume mounts and block the use of theNVIDIA_VISIBLE_DEVICESenvvar for non-SYS_ADMIN containers.Fixes #856