Merged
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up internal CI pipelines by removing unused NGC (NVIDIA GPU Cloud) release and signing stages, and standardizing variable naming conventions to align with other projects.
- Removes entire NGC release and signing workflow including CLI setup and image publishing steps
- Eliminates the unused "sign" stage from the pipeline stages list
- Updates variable naming from
NGC_REGISTRY_STAGING_IMAGE_NAMEto the more consistentNGC_STAGING_REGISTRY/k8s-device-pluginformat
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .nvidia-ci.yml | Removes complete NGC release and signing job definitions (62 lines) |
| .common-ci.yml | Removes "sign" stage and external release template, updates image name variable |
ArangoGutierrez
approved these changes
Jul 24, 2025
Collaborator
ArangoGutierrez
left a comment
There was a problem hiding this comment.
Our new CI pipeline don't require the sign step
Member
Author
Are you asking a question or stating a fact? |
Collaborator
stating a fact |
This was referenced Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes include minor cleanups to the internal CI pipelines. Using variables consistent with other projects and removing unneeded stages.