remove internal logger in favour of klog#1277
Merged
Conversation
4743a87 to
8916894
Compare
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
8916894 to
6d5efa1
Compare
elezar
approved these changes
Jun 5, 2025
Member
elezar
left a comment
There was a problem hiding this comment.
Thanks @tariq1890.
Looks good. Is this a change that you think should be backported?
Contributor
Author
|
Thanks for the review. I don't think this change needs to be backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal logger is an indirect call to the
kloglogger. It's used quite minimally, so I figured we'd just callklogdirectly instead