Updated .release:staging to stage device-plugin images in nvstaging#1230
Merged
cdesiniotis merged 1 commit intoNVIDIA:mainfrom Apr 14, 2025
Merged
Updated .release:staging to stage device-plugin images in nvstaging#1230cdesiniotis merged 1 commit intoNVIDIA:mainfrom
cdesiniotis merged 1 commit intoNVIDIA:mainfrom
Conversation
039730a to
23cd8aa
Compare
Contributor
|
@JunAr7112 the DCO is failing. Please sign off your commit. |
23cd8aa to
662a00b
Compare
elezar
reviewed
Apr 14, 2025
.common-ci.yml
Outdated
| OUT_REGISTRY_USER: "${NGC_REGISTRY_USER}" | ||
| OUT_REGISTRY_TOKEN: "${NGC_REGISTRY_TOKEN}" | ||
| OUT_REGISTRY: "${NGC_REGISTRY}" | ||
| OUT_IMAGE_NAME: "${NGC_REGISTRY_STAGING_IMAGE}" |
Member
There was a problem hiding this comment.
Nit: should this be:
Suggested change
| OUT_IMAGE_NAME: "${NGC_REGISTRY_STAGING_IMAGE}" | |
| OUT_IMAGE_NAME: "${NGC_REGISTRY_STAGING_IMAGE_NAME}" |
Member
There was a problem hiding this comment.
Do we have checks in place to ensure that OUT_IMAGE_NAME is not set? Can we repeat the check we do for the OUT_IMAGE_VERSION:
'echo Version: ${OUT_IMAGE_VERSION} ; [[ -n "${OUT_IMAGE_VERSION}" ]] || exit 1'
to ensure that we don't run this with an empty image name?
Contributor
Author
There was a problem hiding this comment.
Alright, I added a check for OUT_IMAGE_NAME as well.
531acd2 to
07d4cb5
Compare
Signed-off-by: Arjun <arjun.gadiyar@gmail.com>
07d4cb5 to
099def1
Compare
Contributor
|
/ok to test |
@cdesiniotis, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
Contributor
|
/ok to test 099def1 |
cdesiniotis
approved these changes
Apr 14, 2025
This was referenced Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to publish projects with NGC Publishing Configs, the images will need to be staged in the nvstaging registry. This change updates the variables in .release:staging to refer to the NGC registry.