Ensure FAIL_ON_INIT_ERROR boolean env is quoted#1059
Merged
elezar merged 1 commit intoNVIDIA:mainfrom Nov 29, 2024
Merged
Conversation
FAIL_ON_INIT_ERROR boolean env is quoted
e6273ac to
5d5ee79
Compare
Signed-off-by: Unai Arrien <unaittxu@gmail.com>
5d5ee79 to
c999cec
Compare
Member
|
/ok-to-test |
elezar
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting
failOnInitError: truewithin Helm values cause an error due to missing quotes inFAIL_ON_INIT_ERRORenvironment variable after rendering thedaemonset-device-plugin.ymltemplate.This was introduced in 6ed3c9f.
Since the boolean type is validated in the template, we can't set
failOnInitError: "true"as a workaround. I think the only WA possible is setting this configuration via configmap, which the chart also supports but it'd be nice to be able to configure it through thefailOnInitErrorvalue as well.