Honor fail-on-init-error when no resources are found#1033
Merged
elezar merged 1 commit intoNVIDIA:mainfrom Nov 29, 2024
Merged
Conversation
ArangoGutierrez
approved these changes
Oct 31, 2024
cdesiniotis
approved these changes
Nov 25, 2024
tariq1890
reviewed
Nov 25, 2024
cmd/gpu-feature-discovery/main.go
Outdated
| manager := resource.NewManager(infolib, nvmllib, devicelib, config) | ||
| manager, err := resource.NewManager(infolib, nvmllib, devicelib, config) | ||
| if err != nil { | ||
| return err |
Contributor
There was a problem hiding this comment.
Suggested change
| return err | |
| return fmt.Errorf("error instantiating resource manager: %w", err) |
32dd969 to
6efde2f
Compare
As implemented GFD will not fail if no resources are detected -- even if fail-on-init-error is set. This change ensures that fail-on-init-error is honored if no resources are detected. Signed-off-by: Evan Lezar <elezar@nvidia.com>
6efde2f to
e1f1504
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As implemented GFD will not fail if no resources are detected -- even if fail-on-init-error is set. This change ensures that fail-on-init-error is honored if no resources are detected.