Skip to content

Fix default exist error for tigera and custom-resource#499

Merged
shivakunv merged 2 commits intomainfrom
defaultcalicoexistingerror
Sep 10, 2025
Merged

Fix default exist error for tigera and custom-resource#499
shivakunv merged 2 commits intomainfrom
defaultcalicoexistingerror

Conversation

@shivakunv
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 8, 2025

Pull Request Test Coverage Report for Build 17602276453

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 13.121%

Totals Coverage Status
Change from base Build 17593719079: 0.0%
Covered Lines: 272
Relevant Lines: 2073

💛 - Coveralls

@shivakunv shivakunv marked this pull request as ready for review September 8, 2025 18:06
@shivakunv
Copy link
Contributor Author

driver container e2e test successful with this change :
https://github.com/NVIDIA/gpu-driver-container/actions/runs/17529870162

@tariq1890

@shivakunv shivakunv force-pushed the defaultcalicoexistingerror branch from 9cc3de5 to 7aa7824 Compare September 9, 2025 05:09
@shivakunv
Copy link
Contributor Author

@shivakunv shivakunv force-pushed the defaultcalicoexistingerror branch from 7aa7824 to 95c0810 Compare September 9, 2025 06:44
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that @tariq1890 has done a great job reviewing this PR, I'll leave the Approval to him.

@ArangoGutierrez
Copy link
Collaborator

/ok to test 95c0810

Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
@shivakunv shivakunv force-pushed the defaultcalicoexistingerror branch from 95c0810 to 1231ce7 Compare September 9, 2025 16:03
@shivakunv
Copy link
Contributor Author

@tariq1890 @ArangoGutierrez
I'll merge once I test it for gpu-driver-container

@shivakunv shivakunv merged commit 8c753e7 into main Sep 10, 2025
19 checks passed
@shivakunv shivakunv deleted the defaultcalicoexistingerror branch September 10, 2025 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants