Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the NVDriver template to propagate user-supplied Branch and Version settings and refines the default branch logic.
- Propagate
BranchandVersionfields fromenv.Spec.NVIDIADriver - Apply default branch only when both
BranchandVersionare unset
Comments suppressed due to low confidence (1)
pkg/provisioner/templates/nv-driver.go:70
- [nitpick] Consider adding a unit test for this condition to verify that NewNvDriver correctly applies the default branch when both Version and Branch are empty.
if nvDriver.Version == "" && nvDriver.Branch == "" {
Pull Request Test Coverage Report for Build 16345296187Details
💛 - Coveralls |
a5701e0 to
4c70550
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
4c70550 to
9f14fb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.