remove regular gcc install on nvdriver template#377
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom May 30, 2025
Merged
remove regular gcc install on nvdriver template#377ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the installation of the regular gcc package from the nv-driver template and relocates the installation of make to a different package group. Key changes include:
- Removing "gcc make" from the linux-headers installation command.
- Adding "make" to the subsequent package installation command alongside pkg-config.
- Ensuring that gcc is only installed via gcc-12 later in the script.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/provisioner/templates/nv-driver_test.go | Removed gcc and moved make installation to a different package group. |
| pkg/provisioner/templates/nv-driver.go | Removed gcc and moved make installation to a different package group. |
99bc87f to
1d65af1
Compare
eef8914 to
bccaeeb
Compare
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
bccaeeb to
3735840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.