Merged
Conversation
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Multiple fixes after V0.2.10
Comment on lines
+74
to
+77
| instance, err := manager.GetInstance(instanceID) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get instance %s: %v", instanceID, err) | ||
| } |
Collaborator
There was a problem hiding this comment.
Problem: The code retrieves an instance but doesn't check if it exists before attempting to delete it. The error returned might be due to the instance not existing, which should be handled differently than other errors.
Suggested Change: Add specific handling for the case where the instance doesn't exist to provide better error messaging and avoid confusion.
Severity (1 - 4): 3 - MAJOR
Lines: 74-77
Suggested change
| instance, err := manager.GetInstance(instanceID) | |
| if err != nil { | |
| return fmt.Errorf("failed to get instance %s: %v", instanceID, err) | |
| } | |
| instance, err := manager.GetInstance(instanceID) | |
| if err != nil { | |
| if os.IsNotExist(err) { | |
| return fmt.Errorf("instance %s does not exist", instanceID) | |
| } | |
| return fmt.Errorf("failed to get instance %s: %v", instanceID, err) | |
| } |
Generated by Claude 3.5 Sonnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.