Add a safely exit to securly close the ssh connection#369
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom May 26, 2025
Merged
Add a safely exit to securly close the ssh connection#369ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR ensures all provisioner script templates terminate the SSH session cleanly by appending a safe exit marker, and updates corresponding tests to verify its presence.
- Append “# safely close the ssh connection” and
exit 0to every template - Update tests to trim whitespace and assert the safe-exit lines
- (Unintentionally) remove a test that verified temporary directory cleanup in Containerd
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/provisioner/templates/nv-driver.go | Added safe-exit comment and exit 0 to NV driver template |
| pkg/provisioner/templates/nv-driver_test.go | Imported strings, trimmed output, added safe-exit check |
| pkg/provisioner/templates/kubernetes.go | Appended safe-exit lines to all Kubernetes installer templates |
| pkg/provisioner/templates/kubernetes_test.go | Introduced checkSafeExit flag and safe-exit assertions |
| pkg/provisioner/templates/kernel.go | Appended safe-exit lines to kernel script template |
| pkg/provisioner/templates/kernel_test.go | Added test case for safe exit |
| pkg/provisioner/templates/docker.go | Appended safe-exit lines to Docker installation script |
| pkg/provisioner/templates/docker_test.go | Added assertion for safe-exit line |
| pkg/provisioner/templates/crio.go | Appended safe-exit lines to CriO installation script |
| pkg/provisioner/templates/crio_test.go | Added assertion for safe-exit line |
| pkg/provisioner/templates/containerd.go | Appended safe-exit lines to Containerd installation script |
| pkg/provisioner/templates/containerd_test.go | Replaced tmp-dir cleanup test with safe-exit assertion |
| pkg/provisioner/templates/container-toolkit.go | Appended safe-exit lines to toolkit configuration script |
| pkg/provisioner/templates/container-toolkit_test.go | Added assertion for safe-exit line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.