use kubectl create to provision calico CRDs#243
Merged
Conversation
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
3e0d83e to
b3a66f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression introduced by PR #175
I initially switched the kubectl commands from apply to create as apply was idempotent and safer when running commands in a retry loop. However, the
Installation CRDof the Calico Operator is so large that (1.1 MB) that it exceeds the kubernetes annotation size of 262144 bytes (every resource created viakubectl applyhas thekubectl.kubernetes.io/last-applied-configurationannotation added to it)Since the holodeck e2e flakes happen when executing the following command in a retry loop, it should suffice to just
kubectl applythe calicocustom-resources.yamlfile