Add GitHub metadata as AWS Tags#235

Merged

shivakunv merged 1 commit intomainfrom

Dec 19, 2024

Contributor

shivakunv commented Dec 12, 2024

No description provided.

shivakunv force-pushed the ci-dynamicname branch 8 times, most recently from c4e124c to 3d43889 Compare

December 13, 2024 06:11

shivakunv commented

View reviewed changes

.github/dependabot.yml Outdated Show resolved Hide resolved

shivakunv commented

View reviewed changes

.github/dependabot.yml Outdated Show resolved Hide resolved

shivakunv commented

View reviewed changes

.github/workflows/codeql.yml Outdated Show resolved Hide resolved

shivakunv commented

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

shivakunv commented

View reviewed changes

.github/workflows/go.yml Outdated Show resolved Hide resolved

shivakunv commented

View reviewed changes

.github/workflows/go.yml Outdated Show resolved Hide resolved

shivakunv commented

View reviewed changes

.github/workflows/image.yml Outdated Show resolved Hide resolved

shivakunv force-pushed the ci-dynamicname branch 3 times, most recently from 974bb03 to 890030c Compare

December 15, 2024 12:32

shivakunv commented

View reviewed changes

pkg/provisioner/templates/kubernetes.go Outdated Show resolved Hide resolved

shivakunv marked this pull request as ready for review

December 15, 2024 12:38

shivakunv requested review from ArangoGutierrez, cdesiniotis, elezar and tariq1890 as code owners

December 15, 2024 12:38

shivakunv self-assigned this

shivakunv commented

View reviewed changes

cmd/action/ci/ci.go Outdated Show resolved Hide resolved

tariq1890 reviewed

View reviewed changes

pkg/provisioner/templates/kubernetes.go Show resolved Hide resolved

shivakunv force-pushed the ci-dynamicname branch 2 times, most recently from cfdbee7 to aea8944 Compare

December 17, 2024 13:25

Contributor Author

shivakunv commented Dec 18, 2024

cfg.Name = fmt.Sprintf("ci%s-%s-%s", attempt, sha, uid)

is required to maintain uniqueness (in case of workspace deletion or fork repo)

shivakunv force-pushed the ci-dynamicname branch 2 times, most recently from 9228476 to 971df34 Compare

December 18, 2024 08:05

tariq1890 reviewed

View reviewed changes

pkg/provider/aws/aws.go Outdated Show resolved Hide resolved

pkg/provider/aws/aws.go Outdated Show resolved Hide resolved

pkg/provider/aws/aws.go Outdated Show resolved Hide resolved

pkg/provider/aws/aws.go Outdated Show resolved Hide resolved

pkg/provider/aws/aws.go Outdated Show resolved Hide resolved

pkg/provider/aws/aws.go Outdated Show resolved Hide resolved

pkg/provider/aws/aws.go Show resolved Hide resolved

Contributor

tariq1890 commented Dec 18, 2024

@shivakunv Please change the PR Title and Commit message as Add GitHub metadata as AWS Tags

shivakunv force-pushed the ci-dynamicname branch from 971df34 to 9ce6d84 Compare

December 18, 2024 18:41

shivakunv changed the title ~~meta data name support~~ Add GitHub metadata as AWS Tags

tariq1890 reviewed

View reviewed changes

pkg/provider/aws/aws.go Outdated Show resolved Hide resolved

shivakunv force-pushed the ci-dynamicname branch from 9ce6d84 to 661db60 Compare

December 19, 2024 03:09


          Add GitHub metadata as AWS Tags

f1a0a0f

Signed-off-by: shiva kumar <shivaku@nvidia.com>

shivakunv force-pushed the ci-dynamicname branch from 661db60 to f1a0a0f Compare

December 19, 2024 03:16

tariq1890 approved these changes

View reviewed changes

shivakunv merged commit 6783298 into main

tariq1890 deleted the ci-dynamicname branch

December 19, 2024 05:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet