Update DeviceGetconfComputeGpuAttestationReport to take struct as input#159
Merged
klueska merged 1 commit intoNVIDIA:mainfrom Aug 22, 2025
Merged
Update DeviceGetconfComputeGpuAttestationReport to take struct as input#159klueska merged 1 commit intoNVIDIA:mainfrom
klueska merged 1 commit intoNVIDIA:mainfrom
Conversation
This is a BREAKING CHANGE, but one that is necessary, because the API is unusable in its current form. In the C API, the input struct us used to pass _both_ input _and_ output. In our original implementation we didn't take this struct as input, so there was no way to get this input passed into the function. The API has now been updated to correct this. One option could have been to just add the single input field as an input to the API call on its own, but this is not scalable in cases where one my add more input fields to the struct in the future. In the end, (even though this goes against our other wrapper API calls), we decided it was best to just pass the whole struct and assume its usage as both input and output just like the C API. We plan to revisit how to more comprehensively accommodate APIS such as this in the future. Signed-off-by: Kevin Klues <kklues@nvidia.com>
This was referenced Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a BREAKING CHANGE, but one that is necessary, because the API is unusable in its current form. In the C API, the input struct us used to pass both input and output. In our original implementation we didn't take this struct as input, so there was no way to get this input passed into the function. The API has now been updated to correct this.
One option could have been to just add the single input field as an input to the API call on its own, but this is not scalable in cases where one my add more input fields to the struct in the future.
In the end, (even though this goes against our other wrapper API calls), we decided it was best to just pass the whole struct and assume its usage as both input and output just like the C API.
We plan to revisit how to more comprehensively accommodate APIS such as this in the future.