Merged
Conversation
Contributor
|
@rajatchopra for reference: #56, please add test-cases. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for detecting IOMMU file descriptors (IommuFD) on hosts that have iommufd configured and supported. The new field is added to the NvidiaPCIDevice struct to store the IOMMU FD device name.
- Added
IommuFDstring field toNvidiaPCIDevicestruct - Implemented
getIOMMUFD()function to detect vfio device names from thevfio-devdirectory - Integrated IOMMU FD detection into device enumeration with graceful fallback (warning only) when unsupported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…GPUs. Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
Simple test for proper IOMMUFD parsing Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
zvonkok
approved these changes
Nov 24, 2025
Contributor
zvonkok
left a comment
There was a problem hiding this comment.
LGTM, thanks @rajatchopra
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when IommuFD is supported on the host.