Add method IsFabricAttached to Device interface#44

Merged

ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom

ArangoGutierrez:nvmlDeviceGetGpuFabricInfoV

Sep 28, 2024

Collaborator

ArangoGutierrez commented Sep 26, 2024

No description provided.

ArangoGutierrez requested review from elezar and klueska

September 26, 2024 13:17

ArangoGutierrez self-assigned this

ArangoGutierrez mentioned this pull request

Enable labels for IMEX Domain and Clique NVIDIA/k8s-device-plugin#965

Merged

klueska reviewed

View reviewed changes

pkg/nvlib/device/device.go Outdated Show resolved Hide resolved

ArangoGutierrez requested a review from klueska

September 26, 2024 13:32

ArangoGutierrez force-pushed the nvmlDeviceGetGpuFabricInfoV branch from f517219 to 8777666 Compare

September 26, 2024 13:51

klueska changed the title ~~Add method IsImexCapable to Device interface~~ Add method HasGpuFabricInfo to Device interface

klueska reviewed

View reviewed changes

pkg/nvlib/device/device.go Outdated Show resolved Hide resolved

klueska reviewed

View reviewed changes

pkg/nvlib/device/device.go Show resolved Hide resolved

klueska reviewed

View reviewed changes

pkg/nvlib/device/device.go Show resolved Hide resolved

klueska reviewed

View reviewed changes

pkg/nvlib/device/device.go Show resolved Hide resolved

ArangoGutierrez force-pushed the nvmlDeviceGetGpuFabricInfoV branch from 8777666 to d3a1143 Compare

September 26, 2024 14:47

klueska previously approved these changes

View reviewed changes

elezar reviewed

View reviewed changes

pkg/nvlib/device/device.go Outdated Show resolved Hide resolved

ArangoGutierrez dismissed klueska’s stale review via

053e9a8

September 26, 2024 15:12

ArangoGutierrez force-pushed the nvmlDeviceGetGpuFabricInfoV branch from d3a1143 to 053e9a8 Compare

September 26, 2024 15:12

ArangoGutierrez requested a review from elezar

September 26, 2024 15:18

elezar changed the title ~~Add method HasGpuFabricInfo to Device interface~~ Add method IsFabricCapable to Device interface

ArangoGutierrez force-pushed the nvmlDeviceGetGpuFabricInfoV branch from 053e9a8 to 2186ef2 Compare

September 27, 2024 13:19

ArangoGutierrez requested a review from klueska

September 27, 2024 13:20

ArangoGutierrez force-pushed the nvmlDeviceGetGpuFabricInfoV branch from 2186ef2 to 33deea6 Compare

September 27, 2024 13:21

ArangoGutierrez changed the title ~~Add method IsFabricCapable to Device interface~~ Add method IsFabricAttached to Device interface

klueska reviewed

View reviewed changes

pkg/nvlib/device/device.go Outdated Show resolved Hide resolved

klueska reviewed

View reviewed changes

pkg/nvlib/device/device.go Outdated Show resolved Hide resolved

ArangoGutierrez force-pushed the nvmlDeviceGetGpuFabricInfoV branch from 33deea6 to 842c499 Compare

September 27, 2024 13:33


          Add method IsFabricAttached to Device interface

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

ArangoGutierrez force-pushed the nvmlDeviceGetGpuFabricInfoV branch from 842c499 to 9363231 Compare

September 27, 2024 13:42

ArangoGutierrez requested a review from klueska

September 27, 2024 13:45

klueska approved these changes

View reviewed changes

ArangoGutierrez merged commit 41955a0 into NVIDIA:main

gyuho mentioned this pull request

feat(nvidia/nvml): update nvlib to 0.7.0, rename device ID fields leptonai/gpud#114

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet