Add function to get the PCI bus ID for a device#41
Merged
elezar merged 1 commit intoNVIDIA:mainfrom Jun 17, 2024
Merged
Conversation
klueska
reviewed
Jun 11, 2024
Comment on lines
+161
to
+163
| if id != "0000" { | ||
| id = strings.TrimPrefix(id, "0000") | ||
| } |
Collaborator
There was a problem hiding this comment.
If I recall correctly, some systems had 8 leading numbers and some 4. I guess this is handling the case when there are 8 leading numbers but the first 4 are 0000. Is that correct?
visheshtanksale
previously approved these changes
Jun 14, 2024
visheshtanksale
left a comment
There was a problem hiding this comment.
This looks good. Thanks for adding it.
Signed-off-by: Evan Lezar <elezar@nvidia.com>
aa3c471 to
d60aa34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a Device function to return the PCI Bus ID for a Device.