Skip to content

[PyTorch] Get skip_fp8_weight_update only in CUDA Graph Capturing#1854

Merged
ksivaman merged 2 commits into
NVIDIA:mainfrom
yaox12:xiny/fix_cg_for_grouped_linear
Jun 7, 2025
Merged

[PyTorch] Get skip_fp8_weight_update only in CUDA Graph Capturing#1854
ksivaman merged 2 commits into
NVIDIA:mainfrom
yaox12:xiny/fix_cg_for_grouped_linear

Conversation

@yaox12

@yaox12 yaox12 commented Jun 6, 2025

Copy link
Copy Markdown
Member

Description

Let GroupedLinear get skip_fp8_weight_update only in CUDA Graph capturing, to align the behavior of Linear/LayernormLinear.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12 yaox12 requested review from ksivaman and timmoon10 June 6, 2025 10:29
@yaox12

yaox12 commented Jun 6, 2025

Copy link
Copy Markdown
Member Author

/te-ci pytorch

@ksivaman ksivaman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman

ksivaman commented Jun 6, 2025

Copy link
Copy Markdown
Member

/te-ci pytorch

@ksivaman ksivaman merged commit beffb29 into NVIDIA:main Jun 7, 2025
19 of 21 checks passed
@yaox12 yaox12 deleted the xiny/fix_cg_for_grouped_linear branch June 8, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants