fix(sandbox): block direct inet sockets in proxy mode#349
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(sandbox): block direct inet sockets in proxy mode#349drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
NetworkMode::Proxyas allowingAF_INET/AF_INET6socket creation, which lets sandboxed processes open direct IPv4/IPv6 sockets and bypass the proxy allowlist enforcement.Allowmodes, so seccomp must block inet socket domains whenever seccomp network filtering is active.Description
allow_inetbranch and simplifiedbuild_filterto unconditionally includeAF_INETandAF_INET6in the blocked socket domains when seccomp is applied in non-Allowmodes.applyto call the newbuild_filter()signature and preserved the early return forNetworkMode::Allowso existingAllowbehavior remains unchanged.crates/openshell-sandbox/src/sandbox/linux/seccomp.rsand is scoped to the minimal set of edits required to remediate the bypass.Testing
cargo fmt --all -- --checkwhich passed.mise run pre-commitfailed in this environment due to local tool resolution andmise.tomltrust/remote resolution warnings.cargo test -p openshell-sandboxandcargo check -p openshell-sandbox --libwere started but were long-running / blocked by heavy dependency compilation in this environment and could not be completed end-to-end here.Codex Task