fix(sandbox): enforce non-root fallback when process user unset#346
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(sandbox): enforce non-root fallback when process user unset#346drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
run_as_user/run_as_groupand the container runs as root.SYS_ADMIN/NET_ADMINand privilege dropping could be a no-op if the process identity is unset.Description
drop_privilegesincrates/openshell-sandbox/src/process.rsto treat an unset process identity as a security-sensitive case by falling back tosandbox:sandboxwhen running as root, instead of returning early.Testing
crates/openshell-sandbox/src/process.rswere added/adjusted to cover the new fallback semantics fordrop_privileges.cargo fmt --checkwhich succeeded.cargo check -p openshell-sandbox --lib, but full CI/build was not completed within the interactive environment limits.mise run pre-commitwas attempted but failed due to environment/tool resolution and trust issues in this run (not a code failure).Codex Task