fix(sandbox): stop using cmdline paths for binary policy matching#345
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(sandbox): stop using cmdline paths for binary policy matching#345drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/proc/<pid>/cmdlineas binary identities, which are attacker-controlled and allow local processes to spoof an allowed binary and bypass network restrictions.Description
exec.cmdline_pathsso cmdline entries no longer grant binary identity incrates/openshell-sandbox/data/sandbox-policy.rego.exec.pathandexec.ancestors(no cmdline-derived paths) in the same policy file.crates/openshell-sandbox/src/opa.rsto stop relying on cmdline-based allows and to add explicit deny coverage for cmdline spoof attempts, and adjust fixtures to use executable/ancestor path matching.Testing
rgto ensure no Rego rules referenceexec.cmdline_pathsfor identity matching (search succeeded).mise run pre-commitwhich failed in this environment due to remote tool resolution andmisetrust constraints unrelated to the code change.cargo test -p openshell-sandbox cmdline_path_does_not_grant_identity -- --exact, but full native dependency compilation could not complete within this session; the test was added/updated to assert that cmdline entries do not grant identity.Codex Task