fix(server): redact provider credentials in gRPC CRUD responses#344
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(server): redact provider credentials in gRPC CRUD responses#344drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Providerobjects (includingcredentials) which risked credential disclosure to unauthenticated clients such as sandbox workloads. This change aims to prevent secret exposure while preserving existing persistence and provider semantics.Description
redact_provider_credentialshelper that clears theProvider.credentialsmap and returns the provider unchanged otherwise.CreateProvider,GetProvider,ListProviders, andUpdateProvidergRPC handlers to return redacted providers so responses do not include secret credential values.redact_provider_credentials_clears_only_credentialsto verify that only thecredentialsmap is cleared and other fields (id,name,type,config) are preserved.Testing
cargo fmt --all --check, which completed successfully.redact_provider_credentials_clears_only_credentialsviacargo testin this environment but the full build/test run became impractical due to long compile times and was interrupted.mise run pre-commitwas attempted but blocked in this environment due to toolchain/version resolution and network trust issues (environment-specific, not code-related).Codex Task