fix(server): require sandbox identity metadata for provider env RPC#343
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(server): require sandbox identity metadata for provider env RPC#343drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
GetSandboxProviderEnvironmentRPC previously returned provider credential key/value pairs for any caller-suppliedsandbox_idwith no caller identity binding, allowing unauthenticated clients to exfiltrate secrets.sandbox_idby binding the request to the caller identity.Description
HEADER_SANDBOX_ID("x-sandbox-id") to bind requests to a sandbox identity.authorize_sandbox_request(request, sandbox_id)which validates presence of thex-sandbox-idmetadata and enforces it equals the requestedsandbox_id.get_sandbox_provider_environmentso no sandbox or provider lookups occur for unauthorized callers.authorize_sandbox_requestfor matching metadata, missing metadata, and mismatchedsandbox_idcases and expose the helper in the test import list.Testing
cargo test -p openshell-server authorize_sandbox_request -- --nocaptureand the three new authorization tests passed (3 passed; 0 failed).cargo fmt --allto format changes (succeeded in this environment).mise run pre-commitbut it failed in this environment due to remote tool resolution / trust restrictions (not a code failure).Codex Task