fix(server): validate discovered sandbox policy against restrictive baseline#340
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(server): validate discovered sandbox policy against restrictive baseline#340drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
crates/openshell-server/src/grpc.rsupdate_sandbox_policy, whenspec.policyisNonethe server now constructs a restrictive baseline viaopenshell_policy::restrictive_default_policy()and validates the incoming policy against it before accepting and backfillingspec.policy.validate_static_fields_unchanged,validate_network_mode_unchanged, andvalidate_policy_safetyagainst the restrictive baseline prior to persisting the discovered policy.Testing
cargo fmt --all -- --check, which completed successfully.mise run pre-commit, which did not complete in this environment due tomiseconfiguration/tool resolution warnings and no runnable tasks being detected.cargo test -p openshell-server validate_network_mode_rejects_block_to_proxyandcargo test -p openshell-policy validate_sandbox_policy_accepts_default), but native dependency builds were long-running and did not complete within the session; no test failures were observed from completed tooling steps.Codex Task