fix(sandbox): deny forward proxy for l7-configured endpoints#339
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(sandbox): deny forward proxy for l7-configured endpoints#339drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
allowed_ipsvalidation, which allowed sandboxed clients to bypass endpoint L7 method/path rules that are enforced in the CONNECT/L7 inspection path.HTTP_PROXY+ plainhttp://requests to reach endpoints that have L7 policies, closing a high-severity policy bypass.Description
handle_forward_proxy()that callsquery_l7_config(...)and returnsHTTP/1.1 403 Forbiddenwhen the matched endpoint has L7 configuration, so forward-proxy requests cannot bypass per-request L7 inspection.emit_denial_simple(..., "forward_l7")for visibility and auditing.architecture/security-policy.mdto document that forward-proxy requests are rejected for endpoints with L7 config and thatCONNECTmust be used for L7-inspected endpoints.Testing
cargo fmt --all --check, which succeeded.mise run pre-commit, which failed due to environment/tooling remote resolution and trust warnings in this container, not due to code changes.cargo test -p openshell-sandbox --lib proxy::tests -- --nocapture, which began compilation in this environment but did not complete within the session (heavy dependency build); thus unit tests were not fully executed here.Codex Task