fix(server): enforce edge token auth in dual-auth mode#338
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(server): enforce edge token auth in dual-auth mode#338drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
allow_unauthenticated=true) allowed TLS handshakes without client certs but did not enforce any application-layer token checks, leaving the gateway control plane exposed.Description
edge_authhelper module (crates/openshell-server/src/edge_auth.rs) that recognizes edge tokens fromcf-authorization,authorization: Bearer ..., and theCF_Authorizationcookie for both HTTP and gRPC metadata.MultiplexServicethat returnsUNAUTHENTICATEDwhen dual-auth mode is enabled and no edge token is present (crates/openshell-server/src/multiplex.rs)./_ws_tunnelwith HTTP401when dual-auth mode is enabled and the upgrade request lacks an edge token (crates/openshell-server/src/ws_tunnel.rs).crates/openshell-server/src/lib.rs,crates/openshell-server/tests/edge_tunnel_auth.rs,architecture/gateway-security.md).Testing
cargo fmt --allwhich completed successfully to ensure formatting consistency.cargo check -p openshell-server --libandcargo test -p openshell-server edge_tunnel_auth -- --nocapture, but full test completion was blocked in this environment due to long native dependency compilation and network/tooling restrictions; partial compilation proceeded but the full test run did not finish.edge_authhelpers were added and exercised locally where the build proceeded; a full CI run is recommended to validate all integration tests in a normal build environment usingmise run pre-commitandcargo test -p openshell-server.Codex Task