fix(sandbox): default missing process identity before privilege checks#337
Closed
drew wants to merge 1 commit intoNVIDIA:mainfrom
Closed
fix(sandbox): default missing process identity before privilege checks#337drew wants to merge 1 commit intoNVIDIA:mainfrom
drew wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
Collaborator
|
Closing in favor of consolidated re-implementation. See #350 for tracking. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
run_as_user/run_as_groupto skip privilege dropping and run sandboxed children as root, weakening isolation.Description
run_sandboxto retain a mutablepolicyreturned fromload_policyand pass a mutable reference intovalidate_sandbox_userso normalization happens at startup (crates/openshell-sandbox/src/lib.rs).validate_sandbox_usersignature to accept&mut SandboxPolicyand fill missing or emptyprocess.run_as_userandprocess.run_as_groupwith the literal string"sandbox"before verifying the account exists in the image (crates/openshell-sandbox/src/lib.rs).sandboxby the validation function (validate_sandbox_user_fills_missing_process_identityandvalidate_sandbox_user_fills_empty_process_identityincrates/openshell-sandbox/src/lib.rs).sandboxaccount is absent, preserving the preexisting safety check while preventing noop privilege drops.Testing
cargo test -p openshell-sandboxand verified the new testsvalidate_sandbox_user_fills_missing_process_identityandvalidate_sandbox_user_fills_empty_process_identitypassed.cargo fmt --all --checkwhich succeeded in this environment.mise run pre-commitbut it could not complete in this environment due to external tool metadata resolution and task discovery failures (environment/network limitation), so pre-commit hooks were not validated here.Codex Task